[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Towards a cleaner build: select.el
From: |
Eli Zaretskii |
Subject: |
Re: Towards a cleaner build: select.el |
Date: |
Sun, 16 Jun 2019 19:19:33 +0300 |
> From: Lars Ingebrigtsen <address@hidden>
> Cc: Eli Zaretskii <address@hidden>
> Date: Sun, 16 Jun 2019 16:45:20 +0200
>
> In xselect--encode-string:
> select.el:482:24:Warning: `string-make-unibyte' is an obsolete function (as of
> 26.1); use `encode-coding-string'.
>
> It's this code:
>
> ((eq type 'C_STRING)
> ;; If STR is unibyte (the normal case), use it; otherwise
> ;; we assume some of the characters are eight-bit, and
> ;; take their lower 8 bits.
> (setq str (string-make-unibyte str)))
>
> Stefan suggested, I think, that we should just use string-to-unibyte
> here. Eli, do you agree?
Sorry, no, at least not yet. I still cannot wrap my head around that
code, and Kenichi Handa didn't respond to my questions. Please leave
this alone for now, it's still on my todo.
- Re: Towards a cleaner build: select.el, (continued)
- Re: Towards a cleaner build: select.el, Lars Ingebrigtsen, 2019/06/16
- Re: Towards a cleaner build: calc.el, Lars Ingebrigtsen, 2019/06/16
- Re: Towards a cleaner build: calc.el, Lars Ingebrigtsen, 2019/06/16
- Re: Towards a cleaner build: calc.el, Noam Postavsky, 2019/06/16
- Re: Towards a cleaner build: calc.el, Lars Ingebrigtsen, 2019/06/16
- Re: Towards a cleaner build: calc.el, Lars Ingebrigtsen, 2019/06/16
- Re: Towards a cleaner build: calc.el, Stefan Monnier, 2019/06/16
- Re: Towards a cleaner build: calc.el, Lars Ingebrigtsen, 2019/06/16
- Re: Towards a cleaner build: calc.el, Lars Ingebrigtsen, 2019/06/17
- Re: Towards a cleaner build: calc.el, Mattias EngdegÄrd, 2019/06/17
- Re: Towards a cleaner build: select.el,
Eli Zaretskii <=
- Re: Towards a cleaner build: select.el, Lars Ingebrigtsen, 2019/06/16
- Re: Towards a cleaner build: tags, Dmitry Gutov, 2019/06/18
- Re: Towards a cleaner build: tags, Lars Ingebrigtsen, 2019/06/19
- Re: Towards a cleaner build: tags, Lars Ingebrigtsen, 2019/06/20
- Re: Towards a cleaner build: tags, Dmitry Gutov, 2019/06/20
- Re: Towards a cleaner build: tags, Lars Ingebrigtsen, 2019/06/20
- Re: Towards a cleaner build: tags, Dmitry Gutov, 2019/06/20
- Re: Towards a cleaner build: tags, Lars Ingebrigtsen, 2019/06/20
- Re: Towards a cleaner build: eieio, Stefan Monnier, 2019/06/15
- Re: Towards a cleaner build: eieio, Lars Ingebrigtsen, 2019/06/16