emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Remove display member of glyph_string


From: Eli Zaretskii
Subject: Re: [PATCH] Remove display member of glyph_string
Date: Thu, 09 May 2019 20:59:08 +0300

> From: Alex Gramiak <address@hidden>
> Cc: address@hidden
> Date: Thu, 09 May 2019 11:16:06 -0600
> 
> > There's one more instance of FRAME_X_DISPLAY in xdisp.c which was
> > left, and it will fail compilation on non-X platforms.
> >
> > Otherwise, this LGTM, thanks.
> 
> I only see one such instance, and it's surrounded by:
> 
>  #if false && defined HAVE_X_WINDOWS
> 
> So it should be good, no?

That one, yes.  But there's one more, and it isn't conditioned by
HAVE_X_WINDOWS.  Are you maybe looking on a wrong branch?  I'm on
master.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]