Re: [PATCH] Unit tests and lexical-binding for delim-col.el

emacs-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Unit tests and lexical-binding for delim-col.el

From:	Stefan Kangas
Subject:	Re: [PATCH] Unit tests and lexical-binding for delim-col.el
Date:	Wed, 8 May 2019 19:20:05 +0200

Basil L. Contovounesios <address@hidden> writes:
> It is always better to use defun until proven otherwise, see (info
> "(elisp) Inline Functions"). The only reason I used defsubst was to be

> more conservative, but if no-one minds then defun is indeed preferable.

I was similarly trying to be conservative, maybe overly so. I've attached an
updated patch that also gets rid of the defsubst. Thanks again for your
patience.

Stefan Kangas

0001-lisp-delim-col.el-Use-lexical-binding-3.patch
Description: Text Data

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH] Unit tests and lexical-binding for delim-col.el, Stefan Kangas, 2019/05/07
- Re: [PATCH] Unit tests and lexical-binding for delim-col.el, Basil L. Contovounesios, 2019/05/07
  - Re: [PATCH] Unit tests and lexical-binding for delim-col.el, Noam Postavsky, 2019/05/07
  - Re: [PATCH] Unit tests and lexical-binding for delim-col.el, Stefan Kangas, 2019/05/08
    - Re: [PATCH] Unit tests and lexical-binding for delim-col.el, Basil L. Contovounesios, 2019/05/08
    - Re: [PATCH] Unit tests and lexical-binding for delim-col.el, Stefan Kangas <=
    - Re: [PATCH] Unit tests and lexical-binding for delim-col.el, Stefan Kangas, 2019/05/08
    - Re: [PATCH] Unit tests and lexical-binding for delim-col.el, Basil L. Contovounesios, 2019/05/09
    - Re: [PATCH] Unit tests and lexical-binding for delim-col.el, Stefan Monnier, 2019/05/09
    - Re: [PATCH] Unit tests and lexical-binding for delim-col.el, Stefan Kangas, 2019/05/11
    - Re: [PATCH] Unit tests and lexical-binding for delim-col.el, Basil L. Contovounesios, 2019/05/20
    - Re: [PATCH] Unit tests and lexical-binding for delim-col.el, Stefan Kangas, 2019/05/30

Prev by Date: CPP indentation bikeshed (was: Emacs master build failing on RHEL 6.8)
Next by Date: Re: Line height issues with display-line-number-mode
Previous by thread: Re: [PATCH] Unit tests and lexical-binding for delim-col.el
Next by thread: Re: [PATCH] Unit tests and lexical-binding for delim-col.el
Index(es):
- Date
- Thread