Re: Emacs master build failing on RHEL 6.8

[Eli Zaretskii]

> From: Kaushal Modi <address@hidden>
> Date: Tue, 7 May 2019 10:41:55 -0400
> Cc: Paul Eggert <address@hidden>, Emacs developers <address@hidden>
> 
> 4:#define LIBRSVG_MAJOR_VERSION (2)
> 5:#define LIBRSVG_MINOR_VERSION (26)
> 6:#define LIBRSVG_MICRO_VERSION (0)
> 7:#define LIBRSVG_VERSION ""
> 9:#define LIBRSVG_CHECK_VERSION(major,minor,micro) \
> 10:  (LIBRSVG_MAJOR_VERSION > (major) || \
> 11:   (LIBRSVG_MAJOR_VERSION == (major) && LIBRSVG_MINOR_VERSION > (minor))
> || \
> 12:   (LIBRSVG_MAJOR_VERSION == (major) && LIBRSVG_MINOR_VERSION == (minor)
> && LIBRSVG_MICRO_VERSION >= (micro)))
> 
> The version is 2.26.0.

Maybe I'm blind, but I don't see anything wrong here (although
LIBRSVG_VERSION's value looks strange).

Does it help to flush the # characters all the way to the left, and
also to take the conditions in parens?  Like this:

#if GNUC_PREREQ (4, 6, 0)
#pragma GCC diagnostic push
#endif
#if (LIBRSVG_CHECK_VERSION (2, 45, 1)) && (GNUC_PREREQ (4, 2, 0))
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
#endif

> I see " #define LIBRSVG_CHECK_VERSION(major,minor,micro) \" .. note that
> there is no space before the opening bracket .. is that detail important?

Yes, and the lack of space in the macro definition is correct.