emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Scan of regexp mistakes


From: Paul Eggert
Subject: Re: Scan of regexp mistakes
Date: Sat, 9 Mar 2019 09:12:46 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1

Mattias Engdegård wrote:
--- a/lisp/vc/add-log.el
+++ b/lisp/vc/add-log.el
@@ -239,7 +239,7 @@ a case simply use the directory containing the changed 
file."
      ;; wrongly with a non-date line existing as a random note.  In
      ;; addition, using any kind of fixed setting like this doesn't
      ;; work if a user customizes add-log-time-format.
-    ("^[0-9-]+ +\\|^ \\{11,\\}\\|^\t 
\\{3,\\}\\|^\\(Sun\\|Mon\\|Tue\\|Wed\\|Thu\\|Fri\\|Sat\\) [A-z][a-z][a-z] [0-9:+ ]+"
+    ("^[0-9-]+ +\\|^ \\{11,\\}\\|^\t 
\\{3,\\}\\|^\\(Sun\\|Mon\\|Tue\\|Wed\\|Thu\\|Fri\\|Sat\\) [A-Z][a-z][a-z] [0-9:+ ]+"

The [A-z] should become [A-Za-z] rather than [A-Z], right?

From context I think not. It's trying to match a particular English-language date format where month-name abbreviations are always capitalized. The author was too lazy to list the twelve abbreviations.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]