[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: harfbuzz 2f72162: Fix crash in the Cairo build
From: |
Robert Pluim |
Subject: |
Re: harfbuzz 2f72162: Fix crash in the Cairo build |
Date: |
Tue, 18 Dec 2018 14:01:35 +0100 |
Robert Pluim <address@hidden> writes:
> Eli Zaretskii <address@hidden> writes:
>>> I had a quick go at this. Iʼve not measured the memory difference, but
>>> I can do if people thinks this refactor is worth it. Apart from the
>>> unification of the three struct definitions, most of the patch is
>>> mechanical changes.
>>
Given that my cairo build of emacs opens only 4 fonts on startup, and
the freetype one only 2, I think the memory issue is nonexistent.
>> Thanks, this LGTM, and is a significant improvement, IMO. If no one
>> objects in a few days, please push.
>>
>> P.S. Will this have any problems with the harfbuzz branch?
>
> Apart from having to adjust the addition to the struct in question
> done on the harfbuzz branch, I donʼt think so. Probably there will be
> a merge conflict, I can help out with that if needed.
Having looked closer, there might be a few more conflicts, but nothing
too complicated to handle. Mainly a few instances of struct
ftfont_info -> struct font_info
Robert
- Re: harfbuzz 2f72162: Fix crash in the Cairo build, Robert Pluim, 2018/12/14
- Re: harfbuzz 2f72162: Fix crash in the Cairo build, Eli Zaretskii, 2018/12/14
- Re: harfbuzz 2f72162: Fix crash in the Cairo build, Paul Eggert, 2018/12/17
- Re: harfbuzz 2f72162: Fix crash in the Cairo build, Robert Pluim, 2018/12/18
- Re: harfbuzz 2f72162: Fix crash in the Cairo build, Robert Pluim, 2018/12/19
- Re: harfbuzz 2f72162: Fix crash in the Cairo build, Eli Zaretskii, 2018/12/19
- Re: harfbuzz 2f72162: Fix crash in the Cairo build, Stefan Monnier, 2018/12/14