[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Identifying the face between STRETCH and right fringe.
From: |
Robert Pluim |
Subject: |
Re: Identifying the face between STRETCH and right fringe. |
Date: |
Wed, 28 Nov 2018 14:24:59 +0100 |
Eli Zaretskii <address@hidden> writes:
>> Date: Wed, 28 Nov 2018 11:42:40 +0200
>> From: Eli Zaretskii <address@hidden>
>> Cc: address@hidden
>>
>> > From: Robert Pluim <address@hidden>
>> > Cc: address@hidden
>> > Date: Wed, 28 Nov 2018 10:00:53 +0100
>> >
>> > In this particular case extend_face_to_end_of_line has already done:
>> >
>> > default_face =
>> > FACE_FROM_ID_OR_NULL (f, lookup_basic_face (it->w, f,
>> > DEFAULT_FACE_ID));
>> >
>> > so there'd be no additional cost
>>
>> Yes, but this part could (and probably should) be moved to after the
>> 'return', because default_face is not used before that.
>
> And btw, when the default face is remapped, its background color no
> longer has to be the same as the frame's background, right? Which I
> guess is another reason why we use FRAME_BACKGROUND_PIXEL there.
OK, we can stick with that if no other proposals come up.
Moving the default_face lookup down in the function I can test for a
while. Iʼll even remove the _OR_NULL, since we donʼt check for NULL
anywhere anyway.
Robert
- Re: Identifying the face between STRETCH and right fringe., (continued)
- Re: Identifying the face between STRETCH and right fringe., Robert Pluim, 2018/11/27
- Re: Identifying the face between STRETCH and right fringe., Eli Zaretskii, 2018/11/27
- Re: Identifying the face between STRETCH and right fringe., Robert Pluim, 2018/11/27
- Re: Identifying the face between STRETCH and right fringe., Eli Zaretskii, 2018/11/27
- Re: Identifying the face between STRETCH and right fringe., Robert Pluim, 2018/11/27
- Re: Identifying the face between STRETCH and right fringe., Robert Pluim, 2018/11/27
- Re: Identifying the face between STRETCH and right fringe., Eli Zaretskii, 2018/11/28
- Re: Identifying the face between STRETCH and right fringe., Robert Pluim, 2018/11/28
- Re: Identifying the face between STRETCH and right fringe., Eli Zaretskii, 2018/11/28
- Re: Identifying the face between STRETCH and right fringe., Eli Zaretskii, 2018/11/28
- Re: Identifying the face between STRETCH and right fringe.,
Robert Pluim <=
- Re: Identifying the face between STRETCH and right fringe., Eli Zaretskii, 2018/11/28
- Re: Identifying the face between STRETCH and right fringe., Eli Zaretskii, 2018/11/28
- Re: Identifying the face between STRETCH and right fringe., Robert Pluim, 2018/11/28
- Re: Identifying the face between STRETCH and right fringe., Eli Zaretskii, 2018/11/28
- Re: Identifying the face between STRETCH and right fringe., Robert Pluim, 2018/11/28
- Re: Identifying the face between STRETCH and right fringe., Eli Zaretskii, 2018/11/28
- Re: Identifying the face between STRETCH and right fringe., Robert Pluim, 2018/11/28
- Re: Identifying the face between STRETCH and right fringe., Eli Zaretskii, 2018/11/28
- Re: Identifying the face between STRETCH and right fringe., Robert Pluim, 2018/11/29
- Re: Identifying the face between STRETCH and right fringe., Eli Zaretskii, 2018/11/29