[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: scratch/accurate-warning-pos: Solid progress: the branch now bootstr
From: |
Alan Mackenzie |
Subject: |
Re: scratch/accurate-warning-pos: Solid progress: the branch now bootstraps. |
Date: |
Sun, 25 Nov 2018 19:36:15 +0000 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
Hello again, Eli.
On Sun, Nov 25, 2018 at 18:23:30 +0000, Alan Mackenzie wrote:
> On Sun, Nov 25, 2018 at 20:15:30 +0200, Eli Zaretskii wrote:
> > > Date: Sun, 25 Nov 2018 17:59:29 +0000
> > > From: Alan Mackenzie <address@hidden>
> > > Cc: address@hidden, address@hidden, address@hidden,
> > > address@hidden, address@hidden, address@hidden
[ .... ]
> > As I said, I'd be very surprised if using DEFVAR_BOOL would slow down
> > what you did in any significant way, beyond the slowdown due to the
> > comparison and struct member access.
> I'll time it, then we'll know.
[ .... ]
> > > I'm still a little confused as to what a DEFVAR_BOOL is.
> > It's a C 'bool'. Look at defvar_bool the function: its last argument
> > is a pointer to the C counterpart of a DEFVAR_BOOL.
> > You can also use ptype in the debugger to see what it really is, if
> > you want to be absolutely sure.
> OK, thanks for the explanation. I'll change the declaration of that
> variable (and another one) to DEFVAR_BOOL, and tidy up lisp.h to match.
> Then I'll time the resulting Emacs again. :-)
DONE. The resulting Emacs with DEFVAR_BOOL took just the same amount of
time to bootstrap as the same code with DEFVAR_LISP, to within
measurement error.
So, I'll commit the version with the DEFVAR_BOOLs.
> --
> Alan Mackenzie (Nuremberg, Germany).
- Re: scratch/accurate-warning-pos: First tentative successes., (continued)
- Re: scratch/accurate-warning-pos: First tentative successes., Eli Zaretskii, 2018/11/17
- Re: scratch/accurate-warning-pos: Solid progress: the branch now bootstraps., Alan Mackenzie, 2018/11/23
- Re: scratch/accurate-warning-pos: Solid progress: the branch now bootstraps., Charles A. Roelli, 2018/11/25
- Re: scratch/accurate-warning-pos: Solid progress: the branch now bootstraps., Alan Mackenzie, 2018/11/25
- Re: scratch/accurate-warning-pos: Solid progress: the branch now bootstraps., Andreas Schwab, 2018/11/25
- Re: scratch/accurate-warning-pos: Solid progress: the branch now bootstraps., Alan Mackenzie, 2018/11/25
- Re: scratch/accurate-warning-pos: Solid progress: the branch now bootstraps., Eli Zaretskii, 2018/11/25
- Re: scratch/accurate-warning-pos: Solid progress: the branch now bootstraps., Alan Mackenzie, 2018/11/25
- Re: scratch/accurate-warning-pos: Solid progress: the branch now bootstraps., Eli Zaretskii, 2018/11/25
- Re: scratch/accurate-warning-pos: Solid progress: the branch now bootstraps., Alan Mackenzie, 2018/11/25
- Re: scratch/accurate-warning-pos: Solid progress: the branch now bootstraps.,
Alan Mackenzie <=
- Re: scratch/accurate-warning-pos: Solid progress: the branch now bootstraps., Stefan Monnier, 2018/11/25
- Re: scratch/accurate-warning-pos: Solid progress: the branch now bootstraps., Alan Mackenzie, 2018/11/25
- Re: scratch/accurate-warning-pos: Solid progress: the branch now bootstraps., Stefan Monnier, 2018/11/25
- Re: scratch/accurate-warning-pos: Solid progress: the branch now bootstraps., Alan Mackenzie, 2018/11/25
- Re: scratch/accurate-warning-pos: Solid progress: the branch now bootstraps., Stefan Monnier, 2018/11/25
- Re: scratch/accurate-warning-pos: Solid progress: the branch now bootstraps., Alan Mackenzie, 2018/11/26
- Re: scratch/accurate-warning-pos: Solid progress: the branch now bootstraps., Alan Mackenzie, 2018/11/26
- Re: scratch/accurate-warning-pos: Solid progress: the branch now bootstraps., Eli Zaretskii, 2018/11/25
- Re: scratch/accurate-warning-pos: Solid progress: the branch now bootstraps., Andreas Schwab, 2018/11/25
- Re: scratch/accurate-warning-pos: Solid progress: the branch now bootstraps., Alan Mackenzie, 2018/11/25