[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] open bookmark in other frame
From: |
Karl Fogel |
Subject: |
Re: [PATCH] open bookmark in other frame |
Date: |
Fri, 02 Nov 2018 13:55:40 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Pierre-Yves Luyten <address@hidden> writes:
>Hello, here is the change in one single patch, and a few changes to
>commit message.
Hi, Pierre-Yves.
It's always a good idea to test changes in a freshly-built and freshly-started
Emacs. In this case, because there was no ";;;###autoload" marker before
`bookmark-jump-other-frame', invoking that function in a fresh Emacs would
generate an error. For example, for me `bookmark-map' is bound to `C-c B', so
when I did `C-c B 5' (in a new Emacs) I got an error.
The fix is simple -- this change on top of your patch:
--- lisp/bookmark.el
+++ lisp/bookmark.el
@@ -1125,6 +1125,7 @@ bookmark-jump-other-window
bookmark-current-bookmark)))
(bookmark-jump bookmark 'switch-to-buffer-other-window))
+;;;###autoload
(defun bookmark-jump-other-frame (bookmark)
"Jump to BOOKMARK in another frame. See `bookmark-jump' for more."
(interactive
Obviously, I could just add that ";;;###autoload" line myself commit your
patch. But I thought you might want a chance to update the patch and re-post
it, so that you'd have the experience of trying the change before and after.
Either way is fine with me; let me know what you'd like to do.
(If you're not familiar with what the autoload system does, see section 16.5
"Autoload" in the Info pages.)
Best regards,
-Karl
- Re: [PATCH] open bookmark in other frame,
Karl Fogel <=