[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Replace trivial pcase occurrences in the Emacs sources (was: The poo
From: |
Eli Zaretskii |
Subject: |
Re: Replace trivial pcase occurrences in the Emacs sources (was: The poor state of documentation of pcase like things.) |
Date: |
Tue, 23 Oct 2018 18:17:29 +0300 |
> From: Michael Heerdegen <address@hidden>
> Cc: Stefan Monnier <address@hidden>,
> Eli Zaretskii <address@hidden>
> Date: Tue, 23 Oct 2018 15:04:45 +0200
>
> Some time (two years) ago I volunteered to replace lots of the `pcase'
> occurrences in the Emacs sources (back) to cl-case where possible. Lots
> of people wanted this because they found understanding pcase expressions
> hard.
>
> I would like to do that now.
Thank you. If you find places where pcase is used, but a simple cond
will do (without obfuscating the code, of course), please use cond
where appropriate.
> Or has the mood of people changed in the meantime due to the improved
> documentation of `pcase'?
Mine didn't (and I do appreciate the improvement in the docs).
> A question: when I compose the commit message, I can write something
> like "Change all affected callers in all files" instead of listing all
> individual changed functions separately, right?
"All callers changed" is the usual wording.
- Replace trivial pcase occurrences in the Emacs sources (was: The poor state of documentation of pcase like things.), Michael Heerdegen, 2018/10/23
- Re: Replace trivial pcase occurrences in the Emacs sources (was: The poor state of documentation of pcase like things.), Clément Pit-Claudel, 2018/10/23
- Re: Replace trivial pcase occurrences in the Emacs sources, Michael Heerdegen, 2018/10/23
- Re: Replace trivial pcase occurrences in the Emacs sources, Noam Postavsky, 2018/10/23
- Re: Replace trivial pcase occurrences in the Emacs sources, Michael Heerdegen, 2018/10/23
- Re: Replace trivial pcase occurrences in the Emacs sources, Noam Postavsky, 2018/10/23
- Re: Replace trivial pcase occurrences in the Emacs sources, Michael Heerdegen, 2018/10/24
Re: Replace trivial pcase occurrences in the Emacs sources (was: The poor state of documentation of pcase like things.),
Eli Zaretskii <=
- Re: Replace trivial pcase occurrences in the Emacs sources, Stefan Monnier, 2018/10/23
- Re: Replace trivial pcase occurrences in the Emacs sources, Michael Heerdegen, 2018/10/23
- Re: Replace trivial pcase occurrences in the Emacs sources, Stefan Monnier, 2018/10/23
- pcase vs. case (where it could also be used) [Was: Re: Replace trivial pcase occurrences in the Emacs sources], Garreau\, Alexandre, 2018/10/23
- Re: pcase vs. case (where it could also be used) [Was: Re: Replace trivial pcase occurrences in the Emacs sources], Stefan Monnier, 2018/10/23
- Re: pcase vs. case (where it could also be used) [Was: Re: Replace trivial pcase occurrences in the Emacs sources], Garreau\, Alexandre, 2018/10/23
Re: Replace trivial pcase occurrences in the Emacs sources, Eli Zaretskii, 2018/10/24
Re: Replace trivial pcase occurrences in the Emacs sources, Michael Heerdegen, 2018/10/24
Re: Replace trivial pcase occurrences in the Emacs sources, Eli Zaretskii, 2018/10/24
Re: Replace trivial pcase occurrences in the Emacs sources, Michael Heerdegen, 2018/10/24