[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] open bookmark in other frame
From: |
Karl Fogel |
Subject: |
Re: [PATCH] open bookmark in other frame |
Date: |
Wed, 10 Oct 2018 16:35:50 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Marcin Borkowski <address@hidden> writes:
>> people sometimes use several frames, so i would like to make opening
>> bookmark one shot. Attached patch adds two funcs,
>> "bookmark-jump-other-frame" and the equivalent from the bookmarks menu,
>> "bookmark-bmenu-other-frame"
>
>Great idea!
>
>How about a default keybinding?
I also like this patch. (Marcin, I think Pierre-Yves did include a keybinding:
"F" in the bookmark-map -- unless you meant something else by "default
keybinding"?)
Pierre-Yves, have you read the CONTRIBUTE file at the top of the Emacs source
tree (in particular the bit at the top, that points to
https://www.gnu.org/software/emacs/manual/html_node/emacs/Contributing.html)?
While a plain 'git diff' is fine, 'git format-patch ...' might make it easier
to preserve attribution in the most git-like manner. However, we'll be able to
merge it either way.
Also, that way we get your commit message (log message). You can look at the
existing commit history for examples of commit messages, and the CONTRIBUTE
file has some guidance as well.
Best regards,
-Karl