emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] master 51f0ccc: Put follow-mode's engine on pre-redisp


From: Stefan Monnier
Subject: Re: [Emacs-diffs] master 51f0ccc: Put follow-mode's engine on pre-redisplay-hook instead of post-command-hook
Date: Wed, 03 Oct 2018 08:20:30 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

Hi Alan,

>     Put follow-mode's engine on pre-redisplay-hook instead of
>     post-command-hook

Yay!

> +(defun follow-pre-redisplay-function (wins)
> +  (if (or (eq wins t)
> +          (null wins)
> +          (and (listp wins)
> +               (memq (selected-window) wins)))
> +      (follow-post-command-hook)))

I'm not sure it's possible for (selected-window) not to be memq of wins,
but even if it is, it's likely to be extremely rare.  So the above (or ...)
is probably just a complicated way to say `t`.

> +;; The magic little box. This function was formerly called after every
> +;; command.  It is now called before each redisplay operation (see
> +;; `follow-pre-redisplay-function' above), and at the end of several
> +;; search/replace commands.  It retains its historical name.

I wonder why this is still needed.


        Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]