emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] master 425c281 1/3: Allow t as a catch-all condition-c


From: Eli Zaretskii
Subject: Re: [Emacs-diffs] master 425c281 1/3: Allow t as a catch-all condition-case handler (Bug#24618)
Date: Fri, 07 Sep 2018 09:51:50 +0300

> From: Noam Postavsky <address@hidden>
> Date: Thu, 6 Sep 2018 21:01:31 -0400
> Cc: Emacs developers <address@hidden>
> 
>  DEFUN ("condition-case", Fcondition_case, Scondition_case, 2, UNEVALLED, 0,
> -       doc: /* Regain control when an error is signaled.
> -Executes BODYFORM and returns its value if no error happens.
> +       doc: /* Regain control when a condition is signaled.
> +Executes BODYFORM and returns its value if nothing is signaled.
>  Each element of HANDLERS looks like (CONDITION-NAME BODY...)
>  where the BODY is made of Lisp expressions.
> 
> -A handler is applicable to an error if CONDITION-NAME is one of the
> -error's condition names.  A CONDITION-NAME of t applies to any error
> -symbol.  If an error happens, the first applicable handler is run.
> +A handler is applicable to a condition if CONDITION-NAME is one of the
> +condition's names.  A CONDITION-NAME of t applies to any condition
   ^^^^^^^^^^^
This should be "conditions'", I think, as it's plural.

> +name.  If a condition is signaled, the first applicable handler is run.

I find "condition is signaled" slightly confusing, though.  Why not
use "signal" instead?  A "signal" is not necessarily an error, so I
think the root cause for this change will be taken care of.  WDYT?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]