Re: [Emacs-diffs] master cc5325b: Pacify -Wcast-function-type warnings in GCC 8.1

[Ken Brown]

On 8/20/2018 10:18 AM, Andy Moreton wrote:
> On Mon 20 Aug 2018, Ken Brown wrote:
>
> > On 8/17/2018 10:31 AM, Eli Zaretskii wrote:
> > > branch: master
> > > commit cc5325b0bea13bd93478fcee0b035877b3a72290
> > > Author: Andy Moreton <address@hidden>
> > > Commit: Eli Zaretskii <address@hidden>
> > >
> > >       Pacify -Wcast-function-type warnings in GCC 8.1
> > >            * src/w32.h: (get_proc_addr): New function.
> > >       * src/w32fns.c (setup_w32_kbdhook, Ffile_system_info)
> > >       * src/w32uniscribe.c (syms_of_w32uniscribe): Use get_proc_addr.
> >
> > This breaks the Cygwin-w32 build because w32fns.c and w32uniscribe.c don't
> > include w32.h on Cygwin, so get_proc_addr is undefined.  Could the definition
> > of get_proc_addr be moved to a different header that gets included in the
> > Cygwin build?  Maybe w32common.h?
>
> Sorry Ken, I forgot to test this Cygwin as well as mingw32 and mingw64.
> Does something like this patch work for you ?

Yes, that fixes it.

Thanks.

Ken