[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: package.el strings
From: |
Eli Zaretskii |
Subject: |
Re: package.el strings |
Date: |
Sun, 17 Jun 2018 17:33:19 +0300 |
> From: Jean-Christophe Helary <address@hidden>
> Date: Sun, 17 Jun 2018 23:02:08 +0900
> Cc: Emacs developers <address@hidden>
>
> There is indeed another change I want to make but that can wait. It involves
> removing some of the text decorations to be able to straighten some strings.
>
> If there is an agreement to proceed I can do that later. In the meanwhile it
> would be nice if you could first commit the biggest part of the modifications.
Thanks, but there are a couple of hunks I don't understand:
> (defcustom package-archives `(("gnu" .
> - ,(format "http%s://elpa.gnu.org/packages/"
> - (if (gnutls-available-p) "s" ""))))
> + ,(let ((https
> "https://elpa.gnu.org/packages/")
> + (http
> "http://elpa.gnu.org/packages/"))
> + (if (gnutls-available-p) https http))))
> +
Why did you need this change?
> - (dir (expand-file-name (format "archives/%s" name)
> package-user-dir))
> + (dir (expand-file-name (concat "archives/" name)
> package-user-dir))
Same question here.
> - (message "No packages to upgrade.")
> + (message "No packages to upgrade")
I think our style is not to include a period in messages.
- Re: package.el strings, Jean-Christophe Helary, 2018/06/17
- Re: package.el strings,
Eli Zaretskii <=
- Re: package.el strings, Jean-Christophe Helary, 2018/06/17
- Re: package.el strings, Eli Zaretskii, 2018/06/17
- Re: package.el strings, Jean-Christophe Helary, 2018/06/17
- Re: package.el strings, Jean-Christophe Helary, 2018/06/20
- Re: package.el strings, Eli Zaretskii, 2018/06/20
- Re: package.el strings, Jean-Christophe Helary, 2018/06/20
- Re: package.el strings, Noam Postavsky, 2018/06/24
- Re: package.el strings, Jean-Christophe Helary, 2018/06/24
- Re: package.el strings, Noam Postavsky, 2018/06/24
- Re: package.el strings, Jean-Christophe Helary, 2018/06/24