Re: [RFC PATCH] Per-window face support

[Eli Zaretskii]

> Cc: address@hidden
> From: Daniel Colascione <address@hidden>
> Date: Sat, 16 Jun 2018 07:24:13 -0700
> 
> >>> +    if (w) {
> >>> +      Lisp_Object found = assq_no_quit (parameter, w->window_parameters);
> >>> +      if (!NILP (found) && EQ (XCDR (found), value))
> >>> +        match = true;
> >>> +    }
> >>
> >> [...]
> >>
> >> Also, I wonder whether EQ should actually be equal_no_quit, because
> >> the latter would allow parameters with values that are not just
> >> integers or symbols.
> > 
> > I still wonder why we only allow EQ there, it sounds unnecessarily
> > restrictive.
> 
> Because there's no need for greater power. All you need is simple 
> classification.

That's not the Emacs way, IMO.  Being able to use only integers or
symbols as filtering parameters sounds too restrictive to me, and I
see no reason for such restrictions.  Also, the code and the
documentation were clearly written with an eye towards future
extensions, which seems to contradict "no need for greater power".

But if I'm the only one who's bothered by these restrictions, then so
be it.