[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Unnecessarily moving stiff between files considered harmful
From: |
Karl Fogel |
Subject: |
Re: Unnecessarily moving stiff between files considered harmful |
Date: |
Fri, 23 Mar 2018 13:03:08 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Eli Zaretskii <address@hidden> writes:
>Btw, if I'm allowed a gripe: we have too much of this in our history
>already. Just recently I wanted to know when the assertion in
>set_blv_found was born, and was unable to determine this using Git,
>because that function was first a macro, then an inline function, and
>migrated between 2 or 3 files several times. I eventually had to use
>ChangeLog files from old Emacs releases(!) to find out the history of
>this single line. I'm sure Git gurus will come up with some
>convoluted way to do that with Git, and Magit gurus will tell that
>Magit already knows how to do this. But the fact that the usual tools
>of trade fail here is for me a clear indication that we should keep
>this disadvantage in mind when making such changes: there's a non-zero
>price here.
I looked at places in CONTRIBUTE where it might work to add a sentence or two
about this, but didn't see any good places to fit it in, hmm.
I agree, there is a price. (In the case of particular change we were
discussing, I thought the price was worth paying, but there are always going to
be edge-case disagreements about the relative value of moving code vs the
negative effects of the churn.)
- Re: [Emacs-diffs] master b88e7c8: Make transpose-regions interactive (Bug#30343), (continued)
- Re: [Emacs-diffs] master b88e7c8: Make transpose-regions interactive (Bug#30343), Eli Zaretskii, 2018/03/11
- Re: [Emacs-diffs] master b88e7c8: Make transpose-regions interactive (Bug#30343), Richard Copley, 2018/03/15
- Re: [Emacs-diffs] master b88e7c8: Make transpose-regions interactive (Bug#30343), Karl Fogel, 2018/03/16
- Re: [Emacs-diffs] master b88e7c8: Make transpose-regions interactive (Bug#30343), Karl Fogel, 2018/03/20
- Re: [Emacs-diffs] master b88e7c8: Make transpose-regions interactive (Bug#30343), Richard Copley, 2018/03/20
- Re: [Emacs-diffs] master b88e7c8: Make transpose-regions interactive (Bug#30343), Eli Zaretskii, 2018/03/21
- Re: [Emacs-diffs] master b88e7c8: Make transpose-regions interactive (Bug#30343), Karl Fogel, 2018/03/22
- Re: [Emacs-diffs] master b88e7c8: Make transpose-regions interactive (Bug#30343), Eli Zaretskii, 2018/03/22
- Unnecessarily moving stiff between files considered harmful (Was: [Emacs-diffs] master b88e7c8: Make transpose-regions interactive) (Bug#30343), Eli Zaretskii, 2018/03/22
- Re: Unnecessarily moving stiff between files considered harmful,
Karl Fogel <=
- Re: [Emacs-diffs] master b88e7c8: Make transpose-regions interactive (Bug#30343), Stefan Monnier, 2018/03/22
- Re: [Emacs-diffs] master b88e7c8: Make transpose-regions interactive (Bug#30343), Karl Fogel, 2018/03/23
- Re: [Emacs-diffs] master b88e7c8: Make transpose-regions interactive (Bug#30343), Charles A. Roelli, 2018/03/25
- Re: [Emacs-diffs] master b88e7c8: Make transpose-regions interactive (Bug#30343), Eli Zaretskii, 2018/03/25
- Re: [Emacs-diffs] master b88e7c8: Make transpose-regions interactive (Bug#30343), Charles A. Roelli, 2018/03/25
- Re: [Emacs-diffs] master b88e7c8: Make transpose-regions interactive (Bug#30343), Eli Zaretskii, 2018/03/26
- Re: [Emacs-diffs] master b88e7c8: Make transpose-regions interactive (Bug#30343), Juri Linkov, 2018/03/28
- Re: [Emacs-diffs] master b88e7c8: Make transpose-regions interactive (Bug#30343), Karl Fogel, 2018/03/29
- Re: [Emacs-diffs] master b88e7c8: Make transpose-regions interactive (Bug#30343), Eli Zaretskii, 2018/03/29
- Re: [Emacs-diffs] master b88e7c8: Make transpose-regions interactive (Bug#30343), Stefan Monnier, 2018/03/29