Re: Preview: portable dumper

[Paul Eggert]

On 02/19/2018 02:23 PM, Andy Moreton wrote:
> Comments mentioning MAX_RW_COUNT show that somebody checked an invariant
> when writing the comment, but they do not guarantee that the invariant
> will continue to be maintained in future versions of emacs. A check that
> can be enforced by the compiler is preferable.

That "somebody" was me. That is, I looked at all the callers of these 
functions and checked that none of them go above MAX_RW_COUNT. That 
being said, it doesn't hurt to put in an eassert to check this as well 
(thanks, Eli). It would be a pain to check all the callers at 
compile-time, alas.

> Is there a gnulib replacement for read() that works for emacs, so that
> we could use the proper prototype even on Windows ?

There is. However, the Gnulib 'read' does some stuff that the Emacs 
'read' doesn't (and vice versa). Nobody has taken the time to try to 
unify them, and it's possible that unifying them would not be a good 
idea overall.