Re: [PATCH] Fix frameset-restore in the presence of scaling

[Robert Pluim]

Robert Pluim <address@hidden> writes:

> martin rudalics <address@hidden> writes:
>
>>> Running emacs-26 with GDK_SCALING=2, frameset-restore will position
>>> 2nd and subsequent frames incorrectly if they are in the right half of
>>> the screen. Turns out that we're querying GTK for the dimensions of
>>> the display in order to ensure that frames remain on-screen, and those
>>> dimensions need scaling. Patch attached, tested on GTK 3.18, I'd
>>> appreciate if someone with a HiDPI screen and GTK >= 3.22 could
>>> confirm whether it works for them.
>>
>> When 'left' and top' are negative, they specify a frame position
>> relative to the right or bottom edge of the display.  Are such
>> specifications affected/corrected by your patch with scaling on?
>
> They will almost certainly be corrected. My testcase involved
> destop-save, which doesn't use such specifications for frames as far
> as I know, I'll have to do some manual testing.

Negative offsets work correctly with my patch.

Robert