[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Allow inserting non-BMP characters
From: |
Eli Zaretskii |
Subject: |
Re: [PATCH] Allow inserting non-BMP characters |
Date: |
Tue, 26 Dec 2017 06:46:53 +0200 |
> From: Philipp Stephani <address@hidden>
> Date: Mon, 25 Dec 2017 22:01:15 +0100
> Cc: Philipp Stephani <address@hidden>
>
> +/* Return the Unicode code point for the given UTF-16 surrogates. */
> +
> +INLINE int
> +surrogates_to_codepoint (int low, int high)
> +{
> + eassert (char_low_surrogate_p (low));
> + eassert (char_high_surrogate_p (high));
> + return 0x10000 + (low - 0xDC00) + ((high - 0xD800) * 0x400);
> +}
> +
> /* Data type for Unicode general category.
Suggest to move surrogates_to_codepoint to coding.c, and then use the
macros UTF_16_HIGH_SURROGATE_P and UTF_16_LOW_SURROGATE_P defined
there. Also, a single-liner sounds like too little to justify a
function, so maybe make all of that macros in coding.h, and include
the latter in nsterm.m.
> + USE_SAFE_ALLOCA;
> + unichar *utf16_buffer;
> + SAFE_NALLOCA (utf16_buffer, 1, len);
Maximum length of a UTF-16 sequence is known in advance, so why do you
need SAFE_NALLOCA here? Couldn't you use a buffer of fixed length
instead?
Thanks.
- [PATCH] Allow inserting non-BMP characters, Philipp Stephani, 2017/12/25
- Re: [PATCH] Allow inserting non-BMP characters, Alan Third, 2017/12/25
- Re: [PATCH] Allow inserting non-BMP characters,
Eli Zaretskii <=
- Re: [PATCH] Allow inserting non-BMP characters, Philipp Stephani, 2017/12/26
- Re: [PATCH] Allow inserting non-BMP characters, Eli Zaretskii, 2017/12/26
- Re: [PATCH] Allow inserting non-BMP characters, Philipp Stephani, 2017/12/26
- Re: [PATCH] Allow inserting non-BMP characters, Eli Zaretskii, 2017/12/26
- Re: [PATCH] Allow inserting non-BMP characters, Alan Third, 2017/12/26
- Re: [PATCH] Allow inserting non-BMP characters, Eli Zaretskii, 2017/12/26
- Re: [PATCH] Allow inserting non-BMP characters, Alan Third, 2017/12/28
- Re: [PATCH] Allow inserting non-BMP characters, Philipp Stephani, 2017/12/28
- Re: [PATCH] Allow inserting non-BMP characters, Eli Zaretskii, 2017/12/28
- Re: [PATCH] Allow inserting non-BMP characters, Philipp Stephani, 2017/12/29