[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] emacs-26 f274cbd: Avoid reordering of output in 'shr-i
From: |
martin rudalics |
Subject: |
Re: [Emacs-diffs] emacs-26 f274cbd: Avoid reordering of output in 'shr-insert-document' |
Date: |
Mon, 18 Dec 2017 08:26:31 +0100 |
> I think what Eli is getting at is that instead of save-window-excursion
> we could just do add a `set-window-buffer` before `set-window-point`.
>
> I think it would make a lot of sense, actually, since
> save-window-excursion saves the whole window-config (i.e. data about
> all windows in the current frame), whereas we're only going to touch the
> selected window.
`save-window-excursion' is a pain. But as I mentioned in my last mail,
`set-window-buffer' is not so innocuous either. We'd have to care about
the selectd window's old_pointm, start_at_line_beg and start slots at
least. Something `save-window-excursion' (maybe) does auto-magically.
So I doubt we should do such a change in the release.
martin
- Re: [Emacs-diffs] emacs-26 f274cbd: Avoid reordering of output in 'shr-insert-document', Stefan Monnier, 2017/12/16
- Re: [Emacs-diffs] emacs-26 f274cbd: Avoid reordering of output in 'shr-insert-document', Eli Zaretskii, 2017/12/16
- Re: [Emacs-diffs] emacs-26 f274cbd: Avoid reordering of output in 'shr-insert-document', Stefan Monnier, 2017/12/16
- Re: [Emacs-diffs] emacs-26 f274cbd: Avoid reordering of output in 'shr-insert-document', Eli Zaretskii, 2017/12/17
- Re: [Emacs-diffs] emacs-26 f274cbd: Avoid reordering of output in 'shr-insert-document', martin rudalics, 2017/12/17
- Re: [Emacs-diffs] emacs-26 f274cbd: Avoid reordering of output in 'shr-insert-document', Eli Zaretskii, 2017/12/17
- Re: [Emacs-diffs] emacs-26 f274cbd: Avoid reordering of output in 'shr-insert-document', martin rudalics, 2017/12/17
- Re: [Emacs-diffs] emacs-26 f274cbd: Avoid reordering of output in 'shr-insert-document', Stefan Monnier, 2017/12/17
- Re: [Emacs-diffs] emacs-26 f274cbd: Avoid reordering of output in 'shr-insert-document',
martin rudalics <=