Re: Emacs HEAD broken with XPM option in 1b492fa

[Ashish SHUKLA]

On Mon, 04 Sep 2017 21:30:13 +0300, Eli Zaretskii <address@hidden> said:
|| From: Paul Eggert <address@hidden>
|| Date: Mon, 4 Sep 2017 10:50:37 -0700
|| Cc: Noam Postavsky <address@hidden>
|| 
|| > It seems like in e88bbd22[2], author (cc'ed) typo-ed (s/X11/noX/):
|| 
|| A comment before that line says:
|| 
|| ### The Cygwin-w32 build uses <noX/xpm.h> instead of <X11/xpm.h>, so
|| ### we need to set LDFLAGS accordingly.
|| 
|| so presumably the noX is intentional. Perhaps this depends on Cygwin 
versions? 
|| Sorry, I can't be of much help here since I don't use Cygwin.

| The OP was evidently compiling for FreeBSD, so I wonder how that
| compilation ends up in a Cygwin-specific part of the configure
| script.  I guess some configure-time logic misfires on FreeBSD?

Well, if you look carefully, there are two checks involving "noX/xpm.h" code
snippet, one is for Windows/non-X11, and another is for X11. And,
unfortunately both of those checks check for "noX/xpm.h", which I think is
unintentional, and typo on author's part.

-- 
Ashish SHUKLA

“Progress doesn't  come from early risers  – progress is made  by lazy
men looking for easier ways to do things.”
                                              (Robert A. Heinlein, 1973)

Sent from my Emacs

signature.asc
Description: PGP signature