emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master cd0a795: Output number of characters added to file (Bug#354)


From: Mark Oteiza
Subject: Re: master cd0a795: Output number of characters added to file (Bug#354)
Date: Fri, 7 Apr 2017 20:16:00 -0400
User-agent: NeoMutt/20170306 (1.8.0)

On 07/04/17 at 10:14am, Eli Zaretskii wrote:
> > From: Mark Oteiza <address@hidden>
> > Date: Thu, 06 Apr 2017 23:30:41 -0400
> > Cc: Jeff Clough <address@hidden>, Noam Postavsky <address@hidden>
> > 
> > >     Output number of characters added to file (Bug#354)
> > >     
> > >     * fileio.c (write_region):
> > >     * epa-file.el (epa-file-write-region):
> > >     * jka-compr.el (jka-compr-write-region):
> > >     * ange-ftp.el (ange-ftp-write-region):
> > >     * tramp-gvfs.el (tramp-gvfs-handle-write-region):
> > >     * tramp-sh.el (tramp-sh-handle-write-region):
> > >     * mm-util.el (mm-append-to-file): Functions now output
> > >     characters written in addition to file name.
> > >     * files.texi: Added documentation to write-region and
> > >     append-to-file describing their output.
> > 
> > This behavior is unnecessarily verbose, at least when just interactively
> > saving buffers.  Haven't tested this otherwise.  If I cared about the
> > number of characters in the buffer I'd look in the mode line or just do
> > C-x =.
> > 
> > I can't say I've ever been surprised as described in the original
> > report.
> 
> Thanks for the comments.  Would making this an optional feature take
> care of your concerns?

Indeed it would, and IMO it should default to disabled.

> P.S. In the future, it might be better to voice such objections while
> the patch is being discussed, to avoid unnecessary reworking and
> possible frustration caused by that.  TIA.

Of course; however, this only grabbed my attention seeing it after
rebuilding.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]