[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Patch for Emacs 25.2
From: |
Eli Zaretskii |
Subject: |
Re: Patch for Emacs 25.2 |
Date: |
Tue, 17 Jan 2017 17:58:58 +0200 |
> From: Michael Albinus <address@hidden>
> Cc: address@hidden
> Date: Mon, 16 Jan 2017 22:49:38 +0100
>
> In `make-auto-save-file-name', there is twice a test for ang-ftp file names:
>
> --8<---------------cut here---------------start------------->8---
> (not (string-match "^/address@hidden:" result)))
> --8<---------------cut here---------------end--------------->8---
>
> The regexp matches ange-ftp file names like "/address@hidden:". It does not
> match general Tramp syntax, like "/method:address@hidden:" or "/host:". As
> result, on MS Windows there is an error like
>
> --8<---------------cut here---------------start------------->8---
> (let ((buffer-file-name "/method:address@hidden:/path/to/file")
> tramp-auto-save-directory auto-save-file-name-transforms)
> (make-auto-save-file-name))
>
> => "address@hidden"
> --8<---------------cut here---------------end--------------->8---
>
> The patch replaces this regexp by
>
> --8<---------------cut here---------------start------------->8---
> (not (file-remote-p result)))
> --8<---------------cut here---------------end--------------->8---
>
> Then it works as expected:
>
> --8<---------------cut here---------------start------------->8---
> (let ((buffer-file-name "/method:address@hidden:/path/to/file")
> tramp-auto-save-directory auto-save-file-name-transforms)
> (make-auto-save-file-name))
>
> => "/method:address@hidden:/path/to/#file#"
> --8<---------------cut here---------------end--------------->8---
>
> The patch is harmless enough that I propose it for Emacs 25.2.
I see your point, but as the current code exists for quite some time
(more than 11 years), I think we can live with it for one more Emacs
release.
So let's leave this out for Emacs 25.2.
Thanks.