Re: Simplify internal_catch()

[Stefan Monnier]

>> There's a fair bit of
>> 
>> Lisp_Object foo;
>> 
>> foo = ...;
>> 
>> around, indeed, because at some point in the past, some C compilers did
>> not support "Lisp_Object foo = ..." when Lisp_Object is a union type.

> Actually, that kind of code was around because C89 did not allow
> declarations after statements.

In some cases, that's true.

> Even ancient C compilers allowed union-typed
> expressions as initial values for auto variables, and "Lisp_Object foo =
> ..." at block start has been in Emacs since the beginning; it's in the very
> oldest code (dated 1985) committed in the Emacs repository.

At least I know Richard made me undo some "Lisp_Object foo = ..." years
ago, saying that we shouldn't do that because it fails to compile in
some cases (presumably when you used some specific compiler and you also
asked for Lisp_Object to be a union rather than an int).
I did not heed his advice very eagerly, to tell you the truth.


        Stefan