Re: [Emacs-diffs] master b9d6938: Cancel the eldoc timer when switching off eldoc mode

[Michael Heerdegen]

Stefan Monnier <address@hidden> writes:

> >      (kill-local-variable 'eldoc-message-commands)
> >      (remove-hook 'post-command-hook 'eldoc-schedule-timer t)
> > - (remove-hook 'pre-command-hook
> > 'eldoc-pre-command-refresh-echo-area t))))
> > + (remove-hook 'pre-command-hook
> > 'eldoc-pre-command-refresh-echo-area t)
> > +    (when eldoc-timer
> > +      (cancel-timer eldoc-timer)
> > +      (setq eldoc-timer nil)))))
>  
> Hmm... IIUC the timer is global (i.e. shared by all buffers), whereas
> the above code is run when disabling eldoc-mode in one particular
> buffer.  So it doesn't look right.

Yes.

And Lars, please also see bug#19853.  When Dmitry will fix this, I think
this issue here will be fixed as side effect.


Michael.