[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5] Add systemd socket launching support
From: |
Eli Zaretskii |
Subject: |
Re: [PATCH v5] Add systemd socket launching support |
Date: |
Sat, 16 Apr 2016 12:50:27 +0300 |
> From: Matthew Leach <address@hidden>
> Cc: Eli Zaretskii <address@hidden>, Stefan Monnier <address@hidden>
> Date: Sun, 10 Apr 2016 15:06:54 +0100
>
> Here is a new version of the systemd integration & socket-launching
> patches. The main change in this series is providing an interface for
> other socket-launching applications to be integrated, namely
> `set_external_socket_descriptor' in process.c.
>
> Feedback & comments welcome!
Thanks, I pushed it to the master branch.
I think it would make sense to add this feature to the list in
EMACS_CONFIG_FEATURES (see the configure script for how we generate
that list).
A few minor comments, for the future:
. Be consistent in how you quote symbols in the log entries. In this
submission, you sometimes quoted `like this', sometimes 'like
this', and sometimes left the symbols unquoted. Pick one style and
stick to it.
. The way to call out a function name is 'function' (with quotes).
The GNU Coding Standards frown upon using function(), which looks
like a call to the function with no arguments, not what you mean.
Thanks again for working on this.
- [PATCH v5] Add systemd socket launching support, Matthew Leach, 2016/04/10
- Re: [PATCH v5] Add systemd socket launching support, Matthew Leach, 2016/04/14
- Re: [PATCH v5] Add systemd socket launching support, Paul Eggert, 2016/04/17
- Re: [PATCH v5] Add systemd socket launching support, Matthew Leach, 2016/04/17
- Re: [PATCH v5] Add systemd socket launching support, Paul Eggert, 2016/04/18
- Re: [PATCH v5] Add systemd socket launching support, Matthew Leach, 2016/04/18
- Re: [PATCH v5] Add systemd socket launching support, Matthew Leach, 2016/04/21
- Re: [PATCH v5] Add systemd socket launching support, Matthew Leach, 2016/04/26
- Re: [PATCH v5] Add systemd socket launching support, Paul Eggert, 2016/04/26
- Re: [PATCH v5] Add systemd socket launching support, Matthew Leach, 2016/04/27
Re: [PATCH v5] Add systemd socket launching support,
Eli Zaretskii <=