[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] master f2da80d: Ignore invalid base64 encoded embedded
From: |
Stefan Monnier |
Subject: |
Re: [Emacs-diffs] master f2da80d: Ignore invalid base64 encoded embedded images |
Date: |
Sun, 20 Mar 2016 11:26:56 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) |
>>> + (setq payload (ignore-errors
>>> + (base64-decode-string payload))))
>> How 'bout with-demoted-errors?
> I don't think the user cares that much -- if an image fails (whether to
> downloading or being invalid), then eww should just continue signal that
> in the document itself (with a broken image icon or the like). But
> messaging is too much chatter.
Hmm... I guess if payload is not a string at all because download
failed, then indeed we have other indications of the problem and
emitting a message would be redundant (and it's a normal occurrence
anyway), but is it really "normal business" for payload to be
a non-base64 string? I thought this would indicate some really
unexpected circumstance.
Stefan