emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: emacs-25 3722a69: Fix bugs in window resizing code


From: Eli Zaretskii
Subject: Re: emacs-25 3722a69: Fix bugs in window resizing code
Date: Wed, 02 Mar 2016 17:54:09 +0200

> Date: Wed, 02 Mar 2016 09:22:50 +0100
> From: martin rudalics <address@hidden>
> CC: address@hidden, address@hidden
> 
> (1) Don't make this function throw an error when a window cannot be made
> as large as requested but try to make the window as large as possible.
> This was the state before my last change.  Its major disadvantage is
> that enlarging the window may fail silently which makes this differ from
> most other window commands.  And, obviously no code can rely on this
> function to behave predictably either.
> 
> (2) Have this function throw an error when a window cannot be made as
> large as requested.  This is the present state.  Its major disadvantage
> is that packages could rely on this function to never throw an error
> except for a short period in 2011.  Even if we manage to fix all
> occurrences in the emacs-25 code base, there might be still packages in
> the wild that count on the "silent" behavior.
> 
> (3) Have this function throw an error in interactive use as in (1) and
> behave as (2) in non-interactive use.  The disadvantage of this approach
> is that, strictly spoken, we would have to document this function again
> in the Elisp manual, describe its different behaviors and support it
> until further notice.
> 
> We have to decide what to do for emacs-25.

Thanks for this clear summary.

If (3) can be done easily and reliably, I think it's the best
alternative.  That it might need documentation changes shouldn't
frighten us.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]