[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master e870279 1/2: Quick temporary hack to fix curcell refreshing.
From: |
Óscar Fuentes |
Subject: |
Re: master e870279 1/2: Quick temporary hack to fix curcell refreshing. |
Date: |
Wed, 30 Dec 2015 18:38:39 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) |
Please install bugfixes on the emacs-25 branch.
Your change addresses bug#21054, which is a release blocker.
Vincent Belache <address@hidden> writes:
> branch: master
> commit e8702794d46ae032803bf54ffbd71ebde215179c
> Author: Vincent Belaïche <address@hidden>
> Commit: Vincent Belaïche <address@hidden>
>
> Quick temporary hack to fix curcell refreshing.
>
> The problem was caused by change: 2015-04-13 Deprecate `intangible'
> and `point-entered' properties. The problem is that this change has
> removed the (setq ses--curcell t) setting in the ses-command-hook
> function.
>
> * ses.el (ses-check-curcell): replace `(eq ses--curcell t)' by just `t' as
> a condition to call function `ses-set-curcell'. Comment this as a quick
> temporary hack to make it work, as I don't know yet whether a definite
> correction would be to make the ses-set-curcell at every
> ses-check-curcell,
> or to revert to the previous approach, ie marking ses--curcell as
> out-of-date
> at every potentially cursor motion command.
> ---
> lisp/ses.el | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/lisp/ses.el b/lisp/ses.el
> index ec1359b..7347eb8 100644
> --- a/lisp/ses.el
> +++ b/lisp/ses.el
> @@ -1117,7 +1117,11 @@ region, or nil if cursor is not at a cell."
> The end marker is appropriate if some argument is 'end.
> A range is appropriate if some argument is 'range.
> A single cell is appropriate unless some argument is 'needrange."
> - (if (eq ses--curcell t)
> + (if t;; Vincent B.:
> + ;; previously (eq ses--curcell t)
> + ;; this is a quick hack to temporary fix the bug implied by changes
> made by Stefan in
> + ;;
> http://git.savannah.gnu.org/cgit/emacs.git/commit/lisp/ses.el?id=84e0b7dad6f1a8e53261f9b96f5a9080fea681a4
> +
> ;;-------------------------------------------------------------------------
> ;; curcell recalculation was postponed, but user typed ahead.
> (ses-set-curcell))
> (cond
>
> _______________________________________________
> Emacs-diffs mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/emacs-diffs
- Re: master e870279 1/2: Quick temporary hack to fix curcell refreshing.,
Óscar Fuentes <=