Re: Separating obarray handling from abbrevs

[Artur Malabarba]

Przemysław Wojnowski <address@hidden> writes:

> I've extracted basic obarray functionality from abbrev.el into separate
> file (the first patch).

I kinda failed to see the point of this originally, but looking at the
diff I can tell this is a good idea.™

> +(defun obarray-make (&optional size)
> +  "Return a new obarray of size `SIZE' or `obarray-default-size'."

Use SIZE, not `SIZE'. Similarly everywhere else.

> +(defun obarray-get (obarray name)
> +  "Return from obarray `OBARRAY' symbol with `NAME' or nil."

I'd use:
"Return symbol named NAME if it is contained in OBARRAY.
Return nil otherwise."

And I would repeat this throughout the docstrings.

> +(defun obarray-put (obarray name)
> +  "Return form `OBARRAY' symbol with `NAME' or nil.

Why the nil?