[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Debugging emacs memory management
From: |
Eli Zaretskii |
Subject: |
Re: Debugging emacs memory management |
Date: |
Tue, 06 Oct 2015 05:41:22 +0300 |
> From: Dima Kogan <address@hidden>
> Cc: address@hidden, address@hidden, address@hidden
> Date: Mon, 05 Oct 2015 16:21:32 -0700
>
> Dima Kogan <address@hidden> writes:
>
> > Here's the updated patch:
> >
> > diff --git a/src/font.c b/src/font.c
> > index 8e06532..dd574ca 100644
> > --- a/src/font.c
> > +++ b/src/font.c
> > @@ -3981,7 +3981,12 @@ copy_font_spec (Lisp_Object font)
> > pcdr = spec->props + FONT_EXTRA_INDEX;
> > for (tail = AREF (font, FONT_EXTRA_INDEX); CONSP (tail); tail = XCDR
> > (tail))
> > if (!EQ (XCAR (XCAR (tail)), QCfont_entity))
> > - *pcdr = Fcons (XCAR (tail), Qnil), pcdr = xcdr_addr (*pcdr);
> > + {
> > + *pcdr = Fcons (Fcons( XCAR (XCAR (tail)),
> > + XCDR (XCAR (tail))),
> > + Qnil);
> > + pcdr = xcdr_addr (*pcdr);
> > + }
> >
> > XSETFONT (new_spec, spec);
> > return new_spec;
>
> After a bit more testing, I'm happy with this patch. Thoughts about
> merging it?
Let's wait for a few days, and push if not objections.
> Should I open a bug tracker entry to keep track of it?
Might be a good idea, yes. Please mention this thread there, if you
do.
Thanks.
- Re: Debugging emacs memory management, (continued)
- Re: Debugging emacs memory management, Eli Zaretskii, 2015/10/08
- Re: Debugging emacs memory management, Eli Zaretskii, 2015/10/08
- Re: Debugging emacs memory management, Dima Kogan, 2015/10/08
- Re: Debugging emacs memory management, Dima Kogan, 2015/10/08
- Re: Debugging emacs memory management, Andreas Schwab, 2015/10/08
- Re: Debugging emacs memory management, Dima Kogan, 2015/10/08
- Re: Debugging emacs memory management, Eli Zaretskii, 2015/10/08
- Re: Debugging emacs memory management, Dima Kogan, 2015/10/08
- Re: Debugging emacs memory management, Eli Zaretskii, 2015/10/08
- Re: Debugging emacs memory management, Dima Kogan, 2015/10/08
- Re: Debugging emacs memory management,
Eli Zaretskii <=
- Re: Debugging emacs memory management, Dima Kogan, 2015/10/09