[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] fix/no-undo-boundary-on-secondary-buffer-change c7a660
From: |
Stefan Monnier |
Subject: |
Re: [Emacs-diffs] fix/no-undo-boundary-on-secondary-buffer-change c7a6601 1/5: undo-size can count number of boundaries. |
Date: |
Tue, 22 Sep 2015 21:23:37 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) |
> Okay. So, I'll recap, and then explain the logic that I am trying to
> implement.
So, IIUC this undo-buffer-undoably-changed is meant to distinguish "new
change since boundary" from "new change since last timer run").
OK, so we were indeed miscommunicating.
But I get the impression that you didn't pay attention to another part
of the logic that we need: the part that pushes a boundary at the end of
a command. Currently this is done in the C code and is applied only to
the current buffer, but we should change this so it is applied to all
buffers that were modified during the last command.
> - every ten seconds check the size of the undo list, and iff it is
> bigger than undo-limit, and has less than 2 boundaries, add one at the
> start.
Why not just unconditionally add a boundary (i.e. regardless of the undo
list size)? That would make it more useful (because more predictable
and avoid too large undo steps), and would remove the need for
undo-buffer-undoably-changed.
Stefan
- Re: [Emacs-diffs] fix/no-undo-boundary-on-secondary-buffer-change c7a6601 1/5: undo-size can count number of boundaries., Stefan Monnier, 2015/09/15
- Re: [Emacs-diffs] fix/no-undo-boundary-on-secondary-buffer-change c7a6601 1/5: undo-size can count number of boundaries., Phillip Lord, 2015/09/17
- Re: [Emacs-diffs] fix/no-undo-boundary-on-secondary-buffer-change c7a6601 1/5: undo-size can count number of boundaries., Stefan Monnier, 2015/09/17
- Re: [Emacs-diffs] fix/no-undo-boundary-on-secondary-buffer-change c7a6601 1/5: undo-size can count number of boundaries., Phillip Lord, 2015/09/17
- Re: [Emacs-diffs] fix/no-undo-boundary-on-secondary-buffer-change c7a6601 1/5: undo-size can count number of boundaries., Stefan Monnier, 2015/09/18
- Re: [Emacs-diffs] fix/no-undo-boundary-on-secondary-buffer-change c7a6601 1/5: undo-size can count number of boundaries., Phillip Lord, 2015/09/22
- Re: [Emacs-diffs] fix/no-undo-boundary-on-secondary-buffer-change c7a6601 1/5: undo-size can count number of boundaries., Stefan Monnier, 2015/09/22
- Re: [Emacs-diffs] fix/no-undo-boundary-on-secondary-buffer-change c7a6601 1/5: undo-size can count number of boundaries., Phillip Lord, 2015/09/22
- Re: [Emacs-diffs] fix/no-undo-boundary-on-secondary-buffer-change c7a6601 1/5: undo-size can count number of boundaries.,
Stefan Monnier <=
- Re: [Emacs-diffs] fix/no-undo-boundary-on-secondary-buffer-change c7a6601 1/5: undo-size can count number of boundaries., Phillip Lord, 2015/09/23
- Re: [Emacs-diffs] fix/no-undo-boundary-on-secondary-buffer-change c7a6601 1/5: undo-size can count number of boundaries., Stefan Monnier, 2015/09/23
- Re: [Emacs-diffs] fix/no-undo-boundary-on-secondary-buffer-change c7a6601 1/5: undo-size can count number of boundaries., Phillip Lord, 2015/09/29