emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: commit-msg hook


From: Paul Eggert
Subject: Re: commit-msg hook
Date: Tue, 14 Apr 2015 11:32:51 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0

On 04/14/2015 11:01 AM, Eli Zaretskii wrote:
You mean, like below?

Looks good, yes.  Some nits:


--- ./.git/hooks/commit-msg.~5~ 2015-04-12 19:11:27.481125000 +0300
+++ ./.git/hooks/commit-msg     2015-04-14 21:01:14.481125000 +0300
@@ -37,6 +37,8 @@
    at_sign=`LC_ALL=en_US.UTF-8 $awk "$print_at_sign" </dev/null 2>/dev/null`
    if test "$at_sign" = @; then
      LC_ALL=en_US.UTF-8; export LC_ALL
+  else
+    LC_ALL=C; export LC_ALL
    fi
  fi

The duplicate 'export LC_ALL's can be hoisted out of the 'if'.
+    non_print = 
"[\1-\37\177]|\302[\200-\237]|\355([\240-\257]|[\260-\277])[\200-\277]"

"([\240-\257]|[\260-\277])" can be simplified to "[\240-\277]".



reply via email to

[Prev in Thread] Current Thread [Next in Thread]