Re: --enable-gcc-warnings is broken on Fedora 21 by GnuTLS code

[Eli Zaretskii]

> Date: Fri, 26 Dec 2014 09:38:11 -0800
> From: Paul Eggert <address@hidden>
> CC: address@hidden, address@hidden, address@hidden
> 
> Eli Zaretskii wrote:
> > All of the optional libraries use this
> > method, so making GnuTLS an exception is bad for maintenance.
> 
> Then let's change the method everywhere; that avoids the exception.
> The idea is to better decouple the generic code from
> WINDOWSNT-specific DLL issues.  Revised patches attached.

Thanks, the first patch is fine with me, with two gotchas:

> +# define inflateInit2(strm, windowBits) \
> +        inflateInit2_ (strm, windowBits, ZLIB_VERSION, sizeof (z_stream))

This will trigger a redifinition warning from the compiler, since
zlib.h already includes such a #define.

> +static bool
> +load_dll_functions (void)
> +{
> +  LOAD_DLL_FN (library, htmlReadMemory);
> +  LOAD_DLL_FN (library, xmlReadMemory);
> +  LOAD_DLL_FN (library, xmlDocGetRootElement);
> +  LOAD_DLL_FN (library, xmlFreeDoc);
> +  LOAD_DLL_FN (library, xmlCleanupParser);
> +  LOAD_DLL_FN (library, xmlCheckVersion);
> +  return true;
> +}

This won't compile, since 'library' is not defined (it needs to be
passed as an argument).