Re: Using stpcpy

[Dmitry Antipov]

On 12/23/2014 09:47 AM, Paul Eggert wrote:

> Something like the attached patch, perhaps?  Tested on
> both GNU/Linux and Solaris 10 (which lacks stpcpy).

Not quite; in particular, I would prefer (for example, in doc.c):

@@ -137,8 +136,7 @@ get_doc_string (Lisp_Object filepos, bool unibyte, bool 
definition)
        {
          /* Preparing to dump; DOC file is probably not installed.
             So check in ../etc.  */
-         strcpy (name, "../etc/");
-         strcat (name, SSDATA (file));
+         lispstpcpy (stpcpy (name, "../etc/"), file);

rather than:

@@ -137,8 +137,7 @@ get_doc_string (Lisp_Object filepos, bool unibyte, bool 
definition)
        {
          /* Preparing to dump; DOC file is probably not installed.
             So check in ../etc.  */
-         strcpy (name, "../etc/");
-         strcat (name, SSDATA (file));
+         strcpy (stpcpy (name, "../etc/"), SSDATA (file));

(because lispstpcpy can use known length of a Lisp_String and so call memcpy,
which should be faster than strcpy).

Dmitry