Re: [PATCH] gnutls: Add SNI support

[Lars Magne Ingebrigtsen]

Toke Høiland-Jørgensen <address@hidden> writes:

> This patch adds what I think is the required call into GnuTLS to add the
> hostname information on the handshake. Unfortunately I have been unable
> to actually test the patch, since I can't get the git trunk to compile.
> However, I thought I'd post it anyway to maybe get someone else to have
> a look.

Thanks; I'm applying a version of your patch...

> Oh, and there's a bit of a hack in trying to detect whether the hostname
> is an IPv4 or IPv6 literal (in which case the hostname shouldn't be
> included in the handshake). Not sure if omitting that check entirely
> will work, or if there's a better way to detect this case.

... but I left this out.  Does it matter that we send the host name if
we've been given the URL https://01.02.03.04/ or whatever?  First of
all, you'd think that would be kinda rare.  Second of all, does the
library mind getting an IP address as the SNI?

If not, we could just do the SNI always without checking.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no