emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Generalizing find-definition


From: Stefan Monnier
Subject: Re: Generalizing find-definition
Date: Wed, 19 Nov 2014 23:19:28 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux)

>>> +(defvar find-definition-identifier-function nil
>> I suggest you collapse those two function variables into one: if called
>> with a nil value (or without argument), then just find the definitions
>> of "thing at point" and if called with a string, then find the
>> definitions of that identifier.
> Keeping two variables puts that logic in the front-end, so all the
> backends don't have to implement it, and we can change it for everyone
> consistently. 

I think both in the front-end and in many backends, the two cases will
share a lot of code, so using a single var will simplify code in the
front-end and in many backends as well.


        Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]