[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Elpa packages and macro dependencies.
From: |
Stefan Monnier |
Subject: |
Re: Elpa packages and macro dependencies. |
Date: |
Thu, 13 Nov 2014 12:34:48 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) |
> + ;; Call `load' on all files in `pkg-dir' which correspond to
> + ;; provided features. Skip autoloads file since we already
> + ;; evaluated it above.
Please add a to this comment a short explanation for why we do
those loads.
Also I think we should not pay attention to features here, only to file names.
One more thing: we should do those loads *after* the code that updates
load-path.
> + (lambda (x) (let* ((name (file-name-base x))
> + (hist (memq (intern-soft name) features)))
I.e. here we should use `load-history' rather than `features'.
One other thing: we could probably get something more reliable by doing
the following:
1- before loading the autoloads file (and before updating load-path), get
do the `directory-files' call
2- use `locate-library' to see which of those files have previous
"conflicting" files.
3- check in load-history which of those conflicting files have been
already loaded.
4- then load autoloads and updates load-path.
5- then load those files identified at step 3.
Maybe we could use the same mechanism after byte-compilation, so as to
re-re-load the file after it's been byte-compiled. Tho this might just
be asking for trouble.
Stefan