[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Bidi reordering engine upgraded
From: |
Jan Djärv |
Subject: |
Re: Bidi reordering engine upgraded |
Date: |
Fri, 17 Oct 2014 19:45:34 +0200 |
Hello.
16 okt 2014 kl. 09:21 skrev Eli Zaretskii <address@hidden>:
>
> Anyway, it looks like the right fix for this is as follows:
>
> === modified file 'src/xdisp.c'
> --- src/xdisp.c 2014-10-14 18:10:37 +0000
> +++ src/xdisp.c 2014-10-16 07:16:49 +0000
> @@ -2303,9 +2303,6 @@ get_phys_cursor_geometry (struct window
> rectangle as wide as the glyph, but use a canonical character
> width instead. */
> wd = glyph->pixel_width - 1;
> -#if defined (HAVE_NTGUI) || defined (HAVE_NS)
> - wd++; /* Why? */
> -#endif
>
> x = w->phys_cursor.x;
> if (x < 0)
>
>
> I never understood why we subtract 1 pixel from the cursor glyph's
> pixel_width, anyway, and w32 and ns countermanded that, as you see.
> Maybe we should also limit 'wd' from below, so it is at least 1.
>
> Jan, can you comment on these issues and on the proposed patch,
> please?
As you figured out, XDrawRectangle with width 0 and non-zero height draws a
1-pixel width line.
Jan D.
- Re: Bidi reordering engine upgraded, (continued)
- Re: Bidi reordering engine upgraded, Thien-Thi Nguyen, 2014/10/17
- Re: Bidi reordering engine upgraded, Eli Zaretskii, 2014/10/17
- Re: Bidi reordering engine upgraded, Thien-Thi Nguyen, 2014/10/17
- Re: Bidi reordering engine upgraded, Eli Zaretskii, 2014/10/17
- Re: Bidi reordering engine upgraded, Thien-Thi Nguyen, 2014/10/17
- Re: Bidi reordering engine upgraded, Eli Zaretskii, 2014/10/17
- Re: Bidi reordering engine upgraded, Dmitry Antipov, 2014/10/16
- Re: Bidi reordering engine upgraded, Eli Zaretskii, 2014/10/16
- Re: Bidi reordering engine upgraded, Eli Zaretskii, 2014/10/16
- Re: Bidi reordering engine upgraded, Eli Zaretskii, 2014/10/17
- Re: Bidi reordering engine upgraded,
Jan Djärv <=
- Re: Bidi reordering engine upgraded, Eli Zaretskii, 2014/10/17
- Re: Bidi reordering engine upgraded, Stefan Monnier, 2014/10/17
- Re: Bidi reordering engine upgraded, Jan Djärv, 2014/10/18
- Re: Bidi reordering engine upgraded, Eli Zaretskii, 2014/10/18
- Re: Bidi reordering engine upgraded, Eli Zaretskii, 2014/10/18
- Re: Bidi reordering engine upgraded, Jan Djärv, 2014/10/19
- Re: Bidi reordering engine upgraded, Eli Zaretskii, 2014/10/19
- Re: Bidi reordering engine upgraded, Jan Djärv, 2014/10/19
- Re: Bidi reordering engine upgraded, Eli Zaretskii, 2014/10/19
Re: Bidi reordering engine upgraded, grischka, 2014/10/17