[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Bidi reordering engine upgraded
From: |
Dmitry Antipov |
Subject: |
Re: Bidi reordering engine upgraded |
Date: |
Thu, 16 Oct 2014 07:55:53 +0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 |
On 10/15/2014 09:50 PM, Eli Zaretskii wrote:
So once again, I need to ask you to step through x_draw_hollow_cursor,
and see what goes wrong there in this case.
7950 x_draw_hollow_cursor (struct window *w, struct glyph_row *row)
7951 {
7952 struct frame *f = XFRAME (WINDOW_FRAME (w));
7953 struct x_display_info *dpyinfo = FRAME_DISPLAY_INFO (f);
7954 Display *dpy = FRAME_X_DISPLAY (f);
7955 int x, y, wd, h;
7956 XGCValues xgcv;
7957 struct glyph *cursor_glyph;
7958 GC gc;
7959
7960 /* Get the glyph the cursor is on. If we can't tell because
7961 the current matrix is invalid or such, give up. */
1 7962 cursor_glyph = get_phys_cursor_glyph (w);
7963 if (cursor_glyph == NULL)
7964 return;
7965
7966 /* Compute frame-relative coordinates for phys cursor. */
7967 get_phys_cursor_geometry (w, row, cursor_glyph, &x, &y, &h);
2 7968 wd = w->phys_cursor_width;
7969
7970 /* The foreground of cursor_gc is typically the same as the normal
7971 background color, which can cause the cursor box to be invisible.
*/
7972 xgcv.foreground = f->output_data.x->cursor_pixel;
7973 if (dpyinfo->scratch_cursor_gc)
7974 XChangeGC (dpy, dpyinfo->scratch_cursor_gc, GCForeground, &xgcv);
7975 else
7976 dpyinfo->scratch_cursor_gc = XCreateGC (dpy, FRAME_X_WINDOW (f),
7977 GCForeground, &xgcv);
7978 gc = dpyinfo->scratch_cursor_gc;
7979
7980 /* When on R2L character, show cursor at the right edge of the
7981 glyph, unless the cursor box is as wide as the glyph or wider
7982 (the latter happens when x-stretch-cursor is non-nil). */
7983 if ((cursor_glyph->resolved_level & 1) != 0
7984 && cursor_glyph->pixel_width > w->phys_cursor_width)
7985 {
7986 x += cursor_glyph->pixel_width - w->phys_cursor_width;
3 7987 wd -= 1;
7988 }
7989 /* Set clipping, draw the rectangle, and reset clipping again. */
7990 x_clip_to_row (w, row, TEXT_AREA, gc);
4 7991 XDrawRectangle (dpy, FRAME_X_WINDOW (f), gc, x, y, wd, h - 1);
7992 XSetClipMask (dpy, gc, None);
7993 }
At 1), cursor_glyph is GLYPHLESS_GLYPH with pixel_width 1;
at 2), wd is 0;
at 3), wd is -1;
at 4), there is an integer overflow because XDrawRectangle accepts
width and height as unsigned.
Dmitry
- Bidi reordering engine upgraded, Eli Zaretskii, 2014/10/15
- Re: Bidi reordering engine upgraded, Dmitry Antipov, 2014/10/15
- Re: Bidi reordering engine upgraded, Eli Zaretskii, 2014/10/15
- Re: Bidi reordering engine upgraded, Dmitry Antipov, 2014/10/15
- Re: Bidi reordering engine upgraded, Eli Zaretskii, 2014/10/15
- Re: Bidi reordering engine upgraded, Eli Zaretskii, 2014/10/15
- Re: Bidi reordering engine upgraded, Eli Zaretskii, 2014/10/15
- Re: Bidi reordering engine upgraded,
Dmitry Antipov <=
- Re: Bidi reordering engine upgraded, Eli Zaretskii, 2014/10/16
- Re: Bidi reordering engine upgraded, Thien-Thi Nguyen, 2014/10/16
- Re: Bidi reordering engine upgraded, Eli Zaretskii, 2014/10/16
- Re: Bidi reordering engine upgraded, Thien-Thi Nguyen, 2014/10/16
- Re: Bidi reordering engine upgraded, Eli Zaretskii, 2014/10/16
- Re: Bidi reordering engine upgraded, Thien-Thi Nguyen, 2014/10/17
- Re: Bidi reordering engine upgraded, Eli Zaretskii, 2014/10/17
- Re: Bidi reordering engine upgraded, Thien-Thi Nguyen, 2014/10/17
- Re: Bidi reordering engine upgraded, Eli Zaretskii, 2014/10/17
- Re: Bidi reordering engine upgraded, Thien-Thi Nguyen, 2014/10/17