emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] trunk r117640: * keyboard.c (safe_run_hook_funcall): A


From: Stefan Monnier
Subject: Re: [Emacs-diffs] trunk r117640: * keyboard.c (safe_run_hook_funcall): Avoid consing around
Date: Mon, 04 Aug 2014 03:28:30 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux)

>  safe_run_hooks (Lisp_Object hook)
>  {
> -  /* FIXME: our `internal_condition_case' does not provide any way to pass 
> data
> -     to its body or to its handlers other than via globals such as
> -     dynamically-bound variables ;-)  */
>    ptrdiff_t count = SPECPDL_INDEX ();
> +
>    specbind (Qinhibit_quit, hook);
> -
>    run_hook_with_args (1, &hook, safe_run_hook_funcall);
> -
>    unbind_to (count, Qnil);
>  }
 
You remove the comment but don't fix the code accordingly: if the FIXME
is not valid any more, than we should cleanly pass `hook' as argument
rather than let-binding it to inhibit-quit.


        Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]