[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] trunk r117340: * lisp/calculator.el: Lots of revisions
From: |
Stefan Monnier |
Subject: |
Re: [Emacs-diffs] trunk r117340: * lisp/calculator.el: Lots of revisions |
Date: |
Wed, 18 Jun 2014 14:49:16 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) |
>> > * lisp/calculator.el: Lots of revisions
>> > - Kill the calculator buffer after electric mode too.
>> > - Make decimal mode have "," groups, so it's more fitting for
>> > use in money calculations.
>> > - Factorial works with non-integer inputs.
>> > - Swallow less errors.
>> > - Lots of other improvements, but no changes to custom
>> > variables, or other user visible changes (except the above).
>> The above description is the kind of thing that should go into
>> etc/NEWS.
> Shouldn't the NEWS entry list only user-visible changes? (That is,
> only the first three items in the above.)
That's right, I was mostly thinking of the first three (actually, the
first one is probably not worth mentioning).
>> But you forgot to include a ChangeLog entry for that commit.
> Should I add it now?
Yes, please.
>> For the ChangeLog entry, you should instead include details about
>> which parts of the code you changed (see
>> https://www.gnu.org/prep/standards/html_node/Change-Logs.html). You
>> can use "C-x 4 a" (both from the calculator.el and the *vc-diff*
>> buffers) to help you write that.
> (AFAICT, it doesn't help with the actual log message, right?)
It's not intelligent, no, but it does write the file name and function
name, using the proper syntax.
> therefore the changelog file can be auto-generated.
That's the end goal, yes.
Stefan