[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: trunk r114534: Get Ruby's SMIE code to pass the test suite.
From: |
Stefan Monnier |
Subject: |
Re: trunk r114534: Get Ruby's SMIE code to pass the test suite. |
Date: |
Sun, 06 Oct 2013 12:45:20 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) |
>> + * indent/ruby.rb: Port a few cases from automated/ruby-mode-tests.el.
>> + Adjust indentation of continued line to the new SMIE behavior.
> I'm slightly concerned that this makes those tests "fail" in the default
> engine.
It's only one test. And yes, the two indentation styles are different.
I obviously consider SMIE's to be superior, which is why I changed the
ruby.rb file, but I haven't bothered to fix the old engine (not
"default" any more).
> Shouldn't be too much of a problem, though, if SMIE works well.
That's the hope, indeed.
> automation. Do you intend to eventually remove it from
> automated/ruby-mode-tests.el? I'd be firmly against that.
Knowing that it's a sensitive issue, I just stay away from
ruby-mode-tests.el.
> This one doesn't work for me. With SMIE, it indents like this:
> MSG = 'Separate every 3 digits in the integer portion of a number' \
> 'with
> underscores(_).'
I installed a fix to smie.el at the same time. The indentation you show
is the one you get with the old smie.el.
Stefan
- Re: trunk r114534: Get Ruby's SMIE code to pass the test suite., Dmitry Gutov, 2013/10/05
- Re: trunk r114534: Get Ruby's SMIE code to pass the test suite.,
Stefan Monnier <=
- Re: trunk r114534: Get Ruby's SMIE code to pass the test suite., Dmitry Gutov, 2013/10/06
- Re: trunk r114534: Get Ruby's SMIE code to pass the test suite., Stefan Monnier, 2013/10/07
- Re: trunk r114534: Get Ruby's SMIE code to pass the test suite., Dmitry Gutov, 2013/10/21
- Re: trunk r114534: Get Ruby's SMIE code to pass the test suite., Stefan Monnier, 2013/10/21
- Re: trunk r114534: Get Ruby's SMIE code to pass the test suite., Dmitry Gutov, 2013/10/21
- Re: trunk r114534: Get Ruby's SMIE code to pass the test suite., Stefan Monnier, 2013/10/21
- Re: trunk r114534: Get Ruby's SMIE code to pass the test suite., Dmitry Gutov, 2013/10/21
- Re: trunk r114534: Get Ruby's SMIE code to pass the test suite., Stefan Monnier, 2013/10/22
- Re: trunk r114534: Get Ruby's SMIE code to pass the test suite., Stefan Monnier, 2013/10/22