Re: PATCH: vc-git-grep: force git-grep to disable color and pager

[Mitchel Humpherys]

On Wed, Sep 25, 2013 at 10:08 AM, Davis Herring <address@hidden> wrote:
>> This commit adds some command line options to the invocation of `git'
>> in `vc-git-grep' so that git disables all coloring and paging. Without
>> this, I get a warning about my "terminal" not being fully functional
>> and git-grep attempts to use a pager (which means the git-grep process
>> never finishes):
>>
>>     git grep -n -e stuff -- *
>>     WARNING: terminal is not fully functional
>>      CREDITS:14:D: Alpha systems hacking, IPv6 and other network related 
>> stuff
>>     <snip>
>>     :  <-- pager waiting for me to do something
>
> All this (including the warning) is the use of less, not the coloring
> (although git might in theory complain if you try to use coloring with
> no TERM variable or so).  I'd recommend using --no-pager but trying to
> interpret the color rather than suppressing it.
>
> Davis
>

You're absolutely right. I've removed the --no-color flag in this
version and confirmed that highlighting works in the *grep* results
buffer.

Thanks,
Mitch


-- 
"if i had more time i would have written a shorter letter."
--Pascal

vc-git-grep-V2.txt
Description: Text document