Re: trunk r113947: * image.c: Fix animation cache signature memory leak.

[Lars Magne Ingebrigtsen]

Paul Eggert <address@hidden> writes:

>> you didn't test it,
>> because it segfaulted the first time it was called.
>
> I did test it, but evidently not with enough test cases.
> Sorry about the bug.

But it would crash with any (animated) image, because it never allocated
a cache.  If I read the code correctly.  :-)

> To avoid such problems in the future, should we funnel future
> image.c changes through you?

No no.

> Here's a tiny style issue that should be fixed at some point: the
> version you inserted has "strcmp(" in a couple of places where it
> should be "strcmp (".

No, please go ahead and fix.

-- 
(domestic pets only, the antidote for overdose, milk.)
  No Gnus T-Shirt for sale: http://ingebrigtsen.no/no.php
  and http://lars.ingebrigtsen.no/2013/08/twenty-years-of-september.html