emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: code review request for saveplace with dired buffer


From: Glenn Morris
Subject: Re: code review request for saveplace with dired buffer
Date: Fri, 07 Jun 2013 13:25:53 -0400
User-agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)

Karl Fogel wrote:

>>+  (if dired-trivial-filenames (dired-goto-next-nontrivial-file))
>>+  (if (featurep 'saveplace) (save-place-position-dired-cursor)))
>
> There might be a convention of using `when' instead of `if', when
> there's no possibility of an `else' clause.  (I'm not sure about that,
> though, so if someone else is I hope they'll speak up.)

I'm not aware of a convention. Personally I prefer (if foo) rather than
(when foo) if `foo' is a single item, but since (when foo) ==
(if (progn foo)), and the compiler optimizes away the useless progn, it
makes no difference in practice.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]