[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: About commit style
From: |
Andreas Röhler |
Subject: |
Re: About commit style |
Date: |
Sat, 06 Apr 2013 17:46:48 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130307 Thunderbird/17.0.4 |
Am 06.04.2013 17:32, schrieb Stefan Monnier:
Then fix the bugs (one by one, if they are different)
If they're trivial enough, it's perfectly OK to lump them together.
What are "trivial bugs" in this context? Something beyond typos and
whitespace changes?
Bugs which are due to using "just not quite the right code".
E.g. renaming a function/variable to use a proper prefix.
Stefan
Just for completeness it might pay to consider the case of a re-write too.
It must neither fix a bug nor introduce new features but might affect a bunch
of lines.
During such a re-write a couple of steps deserve notice, while some of them
will turn
out not so useful, being revoked before final commit.
Andreas