[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Why timers are now catching errors
From: |
Thierry Volpiatto |
Subject: |
Re: Why timers are now catching errors |
Date: |
Sun, 13 Jan 2013 15:54:50 +0100 |
User-agent: |
Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.2.92 (gnu/linux) |
Stefan Monnier <address@hidden> writes:
>> This change will break many commands using timers.
You should read "annoy", it break nothing, just send repeatedly an
annoying message. (See eldoc-eval.el)
But maybe you are intoducing (temporarily) such code to improve some
timer functions running in emacs ?
> Which part of the change?
--8<---------------cut here---------------start------------->8---
(condition-case-unless-debug err
;; Timer functions should not change the current buffer.
;; If they do, all kinds of nasty surprises can happen,
;; and it can be hellish to track down their source.
(save-current-buffer
(apply (timer--function timer) (timer--args timer)))
(error (message "Error in timer: %S" err)))
--8<---------------cut here---------------end--------------->8---
was
--8<---------------cut here---------------start------------->8---
(condition-case nil [...] (error nil))
--8<---------------cut here---------------end--------------->8---
>> This happen in `timer-event-handler', hope this will not be merged in
>> 24.3...
>
> No, it's only for trunk,
Good, thanks.
--
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997
- Why timers are now catching errors, Thierry Volpiatto, 2013/01/13
- Re: Why timers are now catching errors, Stefan Monnier, 2013/01/13
- Re: Why timers are now catching errors,
Thierry Volpiatto <=
- Re: Why timers are now catching errors, Stefan Monnier, 2013/01/13
- Re: Why timers are now catching errors, Thierry Volpiatto, 2013/01/13
- Re: Why timers are now catching errors, Thierry Volpiatto, 2013/01/13
- Re: Why timers are now catching errors, Thierry Volpiatto, 2013/01/13
- Re: Why timers are now catching errors, Eli Zaretskii, 2013/01/13
- Re: Why timers are now catching errors, Eli Zaretskii, 2013/01/13
- Re: Why timers are now catching errors, Thierry Volpiatto, 2013/01/13
- Re: Why timers are now catching errors, Thierry Volpiatto, 2013/01/13
- Re: Why timers are now catching errors, Eli Zaretskii, 2013/01/13
- Re: Why timers are now catching errors, Thierry Volpiatto, 2013/01/13