Re: /srv/bzr/emacs/trunk r109685: Rely on <unistd.h> to declare 'environ'

[Eli Zaretskii]

These parts of your changes seem to be wrong, or at least
under-documented in ChangeLog: the Windows build does not use
lib/unistd.h.  Why did you make them?

  === modified file 'src/callproc.c'
  --- a/src/callproc.c  2012-08-04 14:17:10 +0000
  +++ b/src/callproc.c  2012-08-19 21:00:09 +0000
  @@ -65,10 +65,6 @@
   #include "nsterm.h"
   #endif

  -#ifndef USE_CRT_DLL
  -extern char **environ;
  -#endif
  -
   #ifdef HAVE_SETPGID
   #if !defined (USG)
   #undef setpgrp

  === modified file 'src/editfns.c'
  --- a/src/editfns.c   2012-08-18 06:06:39 +0000
  +++ b/src/editfns.c   2012-08-19 21:00:09 +0000
  @@ -58,10 +58,6 @@
   #include "window.h"
   #include "blockinput.h"

  -#ifndef USE_CRT_DLL
  -extern char **environ;
  -#endif
  -
   #define TM_YEAR_BASE 1900

   #ifdef WINDOWSNT

  === modified file 'src/emacs.c'
  --- a/src/emacs.c     2012-08-05 21:44:21 +0000
  +++ b/src/emacs.c     2012-08-19 21:00:09 +0000
  @@ -642,10 +642,6 @@
   static void
   malloc_initialize_hook (void)
   {
  -#ifndef USE_CRT_DLL
  -  extern char **environ;
  -#endif
  -
     if (initialized)
       {
         if (!malloc_using_checking)

  === modified file 'src/process.c'
  --- a/src/process.c   2012-08-18 06:06:39 +0000
  +++ b/src/process.c   2012-08-19 21:00:09 +0000
  @@ -1623,9 +1623,6 @@
     /* Use volatile to protect variables from being clobbered by longjmp.  */
     volatile int forkin, forkout;
     volatile int pty_flag = 0;
  -#ifndef USE_CRT_DLL
  -  extern char **environ;
  -#endif

     inchannel = outchannel = -1;